Unable to play DSM files...

Started by Mr. Sound-About, August 29, 2013, 09:13:04

Previous topic - Next topic

Mr. Sound-About

Hello.

Although ModPlug Player can load DSM files, it isn't able to play one of the ones I have. These were taken from a game which used Carlos Hasan's DSM library, and they don't appear to be compressed or encrypted...

http://www.superfighter.com/temp/dsm.rar

Can anyone help?

LPChip

MODPlug player is unfortunately not being developed anymore and isn't open source either. So if it doesn't work, there's nothing we can do to change that.

I would suggest downloading milkytracker. It can open DSM files and then save them as .xm files so they do work in modplug player or other players.

If they don't load in milkytracker either, then either your extraction process did not went well or they actually are encrypted.
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

manx

These DSM files appear to have a slightly different file header from the file header that OpenMPT and maybe others expect. I changed the OpenMPT code so that it also accepts this header.

The next OpenMPT version should be able to load these files.

For now, you can try the current test build: http://buildbot.openmpt.org/builds/auto/openmpt-r2619.7z

Saga Musix

Thanks to manx for the quick fix. ;)
And also...
Quote from: LPChip on August 29, 2013, 09:54:16
So if it doesn't work, there's nothing we can do to change that.
Please don't speak for others. You're not part of the development team.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

LPChip

Quote from: Saga Musix on August 29, 2013, 12:39:24
Thanks to manx for the quick fix. ;)
And also...
Quote from: LPChip on August 29, 2013, 09:54:16
So if it doesn't work, there's nothing we can do to change that.
Please don't speak for others. You're not part of the development team.

I was talking about the closed source MODPlug Player. Are you telling me we actually have the sourcecode for the player?
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Saga Musix

We don't, but the way you wrote this can easily imply that there is no way for us to help this person in any way. As you can see, we were very well able to help him to play these files by changing just a few lines of code.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

LPChip

Ah, I see. My apologies. That was not at all the message I was trying to relay.
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Mr. Sound-About

Quote from: manx on August 29, 2013, 12:33:13
These DSM files appear to have a slightly different file header from the file header that OpenMPT and maybe others expect. I changed the OpenMPT code so that it also accepts this header.

Oh, great. I figured this may be the case, but I have no "normal" DSM files to compare against these. Thanks for having a look.

So I take it the header difference denotes a different revision of the DSM format, yes? It's nice to know that these tunes are now supported, in case anyone else comes across files with the same header.

Quote from: manx on August 29, 2013, 12:33:13The next OpenMPT version should be able to load these files.

Nice. Will the build you sent along be able to download that version as an update? Or should I check back here for it?

Quote from: manx on August 29, 2013, 12:33:13For now, you can try the current test build: http://buildbot.openmpt.org/builds/auto/openmpt-r2619.7z

Works perfect, thanks. I'm glad I came back to check the thread (I almost didn't after reading that first reply).

Saga Musix

#8
Quote from: Mr. Sound-About on August 29, 2013, 19:11:10So I take it the header difference denotes a different revision of the DSM format, yes?
It's not really a different format revision, these files just miss the first 8 bytes ("RIFF" signature) at the beginning and some fields there are reordered for whatever reason. The actual content of these files follows the same format as other well-known DSM files.

By the way, can you confirm that OpenMPT plays these files as expected? They sound a bit poor to me, so there might be some things that are not interpreted correctly.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Mr. Sound-About

#9
Quote from: Saga Musix on August 29, 2013, 19:26:23By the way, can you confirm that OpenMPT plays these files as expected? They sound a bit poor to me, so there might be some things that are not interpreted correctly.

Yes, now that you mention it there do seem to be some discrepancies. The most obvious one I noticed was incorrect tempo on some (but not all) of the tunes.

If someone wants to check against the game they are from, which is the only other way I know how to play them, then here's a link to it...

http://archive.org/details/BattleoftheEras_1020

Of course since its a DOS game, DOSBox or a PC running DOS natively [!] will be needed.

The developer does not have source code for the DSM player he used, I'm afraid. So comparison may be the only way to determine what's going on.

Saga Musix

Thanks, I'll look into it when I find some time. Looking at the debugger, several effects are simply not imported at all, so I'll have to find out what they are actually supposed to do.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

LPChip

While researching DSM, I noticed there are several different tracker formats. Thats why I suggested MilkyTracker. Maybe it plays fine in MilkyTracker?
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Saga Musix

No, Milky's code is identical to ModPlug's code before the fix.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

LPChip

Aha... I guess I should shut my mouth... You clearly know a lot more about the subject than I do, and you have the brains to make suggestions like me... :nuts:
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Mr. Sound-About

Quote from: Saga Musix on August 29, 2013, 23:17:34
Thanks, I'll look into it when I find some time.

Cool, thanks. I look forward to the next update.

Quote from: Saga Musix on August 29, 2013, 23:17:34Looking at the debugger, several effects are simply not imported at all, so I'll have to find out what they are actually supposed to do.

Ah. Well, this may help:

http://www.superfighter.com/temp/beras-dsm.rar

It's the full set of DSMs from the registered version of the game, Battle of the Eras, which was recently released as freeware. The link in my first post contained music from the shareware version of the game.