1.17.02.48 Unjust delete

[Sam_Zen]

Full Version:
OpenMPT v1.17.02.48
Description of the bug:
Pattern editor.
If the record button is disabled, cut and paste some codes is not possible, as it should be.
But deleting a pattern in the pattern row is still possible, as it shouldn't be imo.
How often does it happen?:
Always

[Saga Musix]

I'm not sure about this one. Removing a pattern has nothing to do with record mode, as you can't insert patterns while recording anyway. You can delete/write notes while recording, though.

[LPChip]

The idea is, that if you're in jam mode, all keys for playback are enabled, the rest not. That way you can't accidentally press the wrong key. Atleast thats what Sam is referring to.

I agree that it might be wanted to remove the ability to make any modifications, perhaps even saving.

[älskling]

I disagree, I think disabling record mode should leave everything enabled except entering notes into patterns. So editing volumes and deleting patterns should still be enabled.

To me there's a difference between "editing" (changing values) and "recording" (entering notes) and I don't really see the point of disabling editing effects. The way it works now is quite annoying, what are the odds of someone accidentally trying to paste something while jamming?

[bvanoudtshoorn]

Perhaps this could be resolved by having an "Editing" toggle, like in OpenOffice, in addition to the "Recording Mode" toggle.

[älskling]

Perhaps this could be resolved by having an "Editing" toggle, like in OpenOffice, in addition to the "Recording Mode" toggle.

That's a good compromise, but I don't really see why one would need to turn editing off?

[LPChip]

My bad. I was under the assumtion that it was EDIT mode, like in FT2, not REC mode. That does change the perspective.

[Saga Musix]

What do you think about this? Do we need some more discussion about it?

[LPChip]

Yeah, lets discuss this behavor a bit further, come to a conclusion, and then fix this bug based on that outcome.