.50 Song Properties not saved properly

[BooT-SectoR-ViruZ]

Full Version:
OpenMPT v1.17.02.50

Has the bug occured in previous versions? If yes, please specify version(s):
NO!

Description of the bug:
modplug doesn't save song properties of one specific module properly...
i assumed it might be connected to tempo>255 but it's not.

originally the song is supposed to use rc3 mixing, modern tempo mode and have a tempo of 280 at tickspeed 3
when i open it with the current version it will use original mixing, classic tempo mode and will have 255 at tickspeed 3
also .50 will not recognize which version the song was created and last saved with.

no problems when opening with .48 though.
.49 didn't have any problems either if i remember correctly.


How often does it happen?:
always with this one specific module - no problems with similar modules though

How to reproduce (step by step description):
developers will be provided with a link to the module after requesting it

[Saga Musix]

also .50 will not recognize which version the song was created and last saved with.

i also wondered about this one already.

[Relabsoluness]

Damn, this is quite bad bug. Loading of IT files might fail causing song properties(tempo, volume levels etc.) and certain (extended)instrument properties to be left unloaded. This is most likely to occur with IT files made with older version but saved with .50, but can also occur for files saved with older versions. If one saves the file after the incomplete loading, those properties will be lost.

Edit: Corrected the description

[BooT-SectoR-ViruZ]

the song was created with .48 or .49

There are workarounds, but for now I just hope this hasn't caused bad problems.

nope... as long as i load the module with .48 everything is fine

[Relabsoluness]

the song was created with .48 or .49

OK, yes it seems that the loading may fail regardless of the version with which the file was last saved with (see my previous post); 'created with'-version doesn't matter.

[le_parasite]

In "Instruments" pitch tempo / lock" value is lost too when the song is closed...

[Relabsoluness]

In "Instruments" pitch tempo / lock" value is lost too when the song is closed...

Indeed that's among the extended instrument properties whose loading may fail, but a slight correction though. The property is not lost when saving, but instead it's not loaded correctly - opening the file in version .48 or .49 works(?) fine.

[le_parasite]

In "Instruments" pitch tempo / lock" value is lost too when the song is closed...

Indeed that's among the extended instrument properties whose loading may fail, but a slight correction though. The property is not lost when saving, but instead it's not loaded correctly - opening the file in version .48 or .49 works(?) fine.

yeah, I was glad to see that!

[Saga Musix]

any chance that there will be a quick fix soon...?

[le_parasite]

any chance that there will be a quick fix soon...?

it's a major bug that prevent me from further use.

[Relabsoluness]

any chance that there will be a quick fix soon...?

Things are in a state that a quick fix doesn't seem likely. If you really want to use .50 despite all its bad bugs(this, the MIDI mapping bug, and who knows what else), you can try a workaround for this bug:

When opening of a IT-file last saved with some earlier version works correctly, in song properties set all modflags to zero, don't add any MIDI mapping entries and set "restart"-setting in general tab to zero. Such IT file saved with .50 should also load fine in .50.

[Saga Musix]

It seems to be fixed!