.48 MPT gets confused when adding VSTs?

[Saga Musix]

Full Version:
OpenMPT v1.17.02.48

Has the bug occured in previous versions? If yes, please specify version(s): (This option is optional, and doesn't need research. But in case you know...)
not tested


Description of the bug:
When I add new VST plugins to VST selection dialogue, modplug really goes crazy! When I load a new module (possibly also happens with the currently loaded module, dunno), wrong Plugins are selected. For example, there should be an Equalizer Plugin be in my song, but actually a different effect is used! After restarting Modplug, it does not happen anymore.
I guess MPT gets a bit confused with the order of VSTs in the cache..

Edit: Moved to the issue tracker: http://bugs.openmpt.org/view.php?id=25

[LPChip]

I guess this could happen if several VST effects have the same identifier. Each plugin has a 4 char identifier. This is set inside the plugin.

Not sure if this is related to the problem, but its the first thing that I could think of.

[Saga Musix]

I noticed that it JS Equalizer changed to JS Vibrato... You might be right here, maybe all JS plugins have the same identifier...

[pelya]

VST manufacturer should set different identifiers for all of it's VSTs. Maybe DLL filenames for different VSTs are equal. You may open your "plugin.cache" in Notepad and check those long numbers and filenames inside - if you'll find one that points to different DLLs that means the problem is with VSTs, not with MPT (I doubt it however).

[Saga Musix]

Code Select Expand


JS 6 Equalizer V1.0=567374504761696E
567374504761696E.Flags=0
JS Band Cut V1.0=567374504761696E
JS Compresseur V1.0=567374504761696E
JS Compresseur V1.1=567374504761696E
JS Disto V1.0=567374504761696E
JS Equalizer V1.0=567374504761696E
JS Humanizer V1.0=567374504761696E
JS Limiteur V1.0=567374504761696E
JS Magneto V1.1=567374504761696E
JS Mini-Sample V1.0=567374504761696E
JS Noise Attenuateur V1.0=567374504761696E
JS Noise Filtre V1.0=567374504761696E
JS Oscil Resonne V2.0=567374504761696E
JS Oscil Resonne V3.0=567374504761696E
JS PanDelay V3.0=567374504761696E
JS Resonnateur V1.0=567374504761696E
JS Vibrato V1.0=567374504761696E

:oops:  :oops:
is there any way to improve this not only by using a hex editor, but by improving mpt?

[Sam_Zen]

Imo MPT isn't the first one that should fix this. As pelya stated, each plugin should have a different identifier.
What's the point of calling something an 'identifier' if all codes of the items are the same ?
2 Jojo
Did you already used the hex editor to see what happens ?

[Saga Musix]

No, didn't change any bytes as i don't know where they are
I didn't have such problems in other VST hosts, so i think indeed that there has to be something done...

[pelya]

Made hackish-fix in Modplug - it will generate first 4 bytes of Plugin ID as CRC32 of DLL filename instead of "VstP" magic. Get it , backup your MPT installation, overwrite EXE and delete "plugin.cache" file - it should recreate it on start (if it will crash remove and add again all of these JS plugins from Plugin Manager).

[Saga Musix]

there were no troubles with the loading process, however i can't use ASIO with this release anymore. "Unable to open sound device"...

[pelya]

Oh. First bugreport on my custom MinGW build   using ASIO4All driver crashes MPT, hehe, should debug it  
Hey Jojo, thanks for being labrat  

[BooT-SectoR-ViruZ]

oh, this explains my previous trobles with JS plugins... lucky i don't use them anymore...  
(guess for what reason...)

[LPChip]

Since this bug is actually not a bug in OpenMPT, but a faulty use of VST design specs. What are we going to do with this? Is Pelya's fix included in newer builds and if not, do we actually want to present a fix for plugins that screw with the design specs?

[Saga Musix]

Pelya's fix was insufficient (it broke the VST preset loader) and the problem still remains. However, since other apps have no problems with those plugins, I'd say that it would not be the wrong choice to fix this at some point.