Remove that annoying confirmaton popup when creating a new sample

[phanoo]

Hi,
Just a simple and easy life improvement, i am constantly dealing with that popup "This sample is not used by any instrument. Do you want to create a new instrument using this sample ?". I don't care about the outcome (creating a new instrument for it or not), i just want to create a new sample.
Could you add an option to disable that popup? (maybe two options : create an instrument by default, or don't create an instrument)

[Saga Musix]

This prompt is one of the first candidates for converting to a task dialog, together with a checkbox to remember the choice for the duration of the current session. Would this be an acceptable solution for you, or would a single prompt per session still be too much?

[phanoo]

Thanks! I think it would be a good enough solution. My sessions usually last for days or weeks 

[n0cturn]

Can't it be moved to a button on the sample page? 'Create instrument'. I too find that popup windows gets in the way too often, but a remember choice would suffice.

[phanoo]

Since there is already a dropdown menu available for the create new sample button, a new line "Create associated instrument" could be added which would be a check on/off that is remembered within the settings.

[Saga Musix]

We can add many buttons to the user interface. Whether they make sense in the workflow of most users is a completely different question though. Creating a new instrument for newly-created samples is the most important workflow here and if this was no longer the default action when adding new samples, I can already tell you that most users would be completely confused that they first have to dive into a menu they probably never noticed before - there would be tons of questions why adding a new sample no longer makes it accessible in the pattern.
But on the other hand, there are also valid use cases for not creating a new instrument (e.g. when you want to create a multisampled instrument), which are probably less common but still important to be supported.
There's a few options to be explored here. If we want to get rid of the prompt completely, it would probably make more sense to add a "Create sample without instrument" option to the dropdown, not the other way around.

[phanoo]

Yeah I very much know how difficult it can be to design a well-thought UI. I wouldn't mind if the default is to create an instrument. I probably belong to the minority here, using OpenMPT to design multisamples for work (and occasionnally composing tunes as a hobby)

[Saga Musix]

Upon closing inspection, I'm not so sure anymore that adding a menu entry isn't gonna solve the problem in a way that scales. The dialog may currently pop up in any of the given situations:
- Create empty sample slot
- Duplicate sample slot
- Open more than one sample
- Open more than one raw sample

To keep OpenMPT as flexible as it was before, this would require a total of four new menu entries to be added, and I think this would add quite a bit confusion if every dropdown menu entry existed twice (with / without instrument creation). That's not good.