Author Topic: Custom per pattern timesig / row highlight  (Read 11280 times)

Offline Skaven

  • Workaholic artist
  • ***
  • Posts: 112
    • http://www.mikseri.net/skaven
Custom per pattern timesig / row highlight
« on: July 26, 2010, 13:59:24 »
I've been working on game projects that have multiple sub-tunes, and some of the sub-tunes use a bit more exotic beats, like 3/4 while others are in 4/4. But the time signature -derived row highlight is forced throughout the project file. It can be changed to make sub-tune authoring easier, but it's a bit of a chore to switch forth and back.

Would it be technically possible to make it so that the user can specify the time signature per pattern? It could be put behind an "Enable" checkbox, so that by default the patterns use the project's default time signature, but some patterns could use a different one.

If a pattern with a custom time signature is Duplicated, the time signature property would naturally also duplicate.
« Last Edit: November 07, 2010, 17:22:01 by Jojo »

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #1 on: July 26, 2010, 14:15:52 »
Technically it would sure be possible, but at the moment I cannot quite estimate how much work it would be. Sounds like an exciting feature worth looking into, though.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Snu

  • Workaholic artist
  • ***
  • Posts: 320
  • Gender: Male
    • http://www.snuq.com
  • Operating System: Windows 7 64bit
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #2 on: August 01, 2010, 17:09:16 »
i would be very interested in this feature as well!
the thing is, i would want some way of changing the hilighting partway through the song, not just for each subtune.  not really sure how that would work tho, i imagine it would be rather more difficult... maybe some way of doing it on a per-pattern basis through the pattern properties dialog? or maybe another special separator pattern (like the '+++' patterns) that would set the time signature for the patterns after it?

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #3 on: August 01, 2010, 17:11:56 »
Quote from: "Snu"
maybe some way of doing it on a per-pattern basis through the pattern properties dialog?

That's how I imagined it to work at least.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Snu

  • Workaholic artist
  • ***
  • Posts: 320
  • Gender: Male
    • http://www.snuq.com
  • Operating System: Windows 7 64bit
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #4 on: August 01, 2010, 17:14:51 »
oh wow, quick reply, even before i edited the post!
good to know, just wanted to make sure.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #5 on: August 01, 2010, 22:10:03 »
This is working better than expected... The engine was already well prepared for such a feature.

» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Paul Legovitch

  • Workaholic artist
  • ***
  • Posts: 145
    • http://legovitch.blogspot.com
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #6 on: August 01, 2010, 22:21:32 »
Exactly what I need too !  :D

Offline bvanoudtshoorn

  • Extreme artist
  • *****
  • Posts: 1,053
  • Gender: Male
    • Barryvan
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #7 on: August 02, 2010, 00:44:56 »
Sounds good! I've been hankering after this feature for a while!

(And yes, I am still alive, my rather extended silence notwithstanding. :))

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #8 on: August 02, 2010, 18:59:26 »
Hmm.. I'm not quite sure what to do with that Rows per Beat edit control in the main toolbar. It seems so useless to me and it doesn't make much sense to use this together with per-pattern time signatures. Does anyone actually use this feature?
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Paul Legovitch

  • Workaholic artist
  • ***
  • Posts: 145
    • http://legovitch.blogspot.com
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #9 on: August 02, 2010, 21:19:05 »
Quote from: "Jojo"
it doesn't make much sense to use this together with per-pattern time signatures.

I seem to miss the point, how is this a problem ?
It's very useful in Modern tempo mode, at least to remind you of the current time signature, so if you remove it from there I guess you plan to put it somewhere in the pattern editor gui, right ?
If you plan to only have this in the pattern properties dialog, I will miss it for sure and quite frankly I'd prefer to let it where it is.
Perhaps make it so that it always displays the current time sig (and not only when playing).

Btw, what I would use in the main toolbar is a TAP button to set the bpm with mouse clicks.
click...click -> 133bpm  8)

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #10 on: August 02, 2010, 21:48:33 »
Quote from: "Paul Legovitch"
I seem to miss the point, how is this a problem ?

What is the spin button next to it supposed to change? The default rows per beat or the rows per beat for this pattern? Why are there just rows per beat, and not also rows per measure? Are the changes permanent or temporary?
Up until recently, changing the RPB using this spin control didn't even mark the module as modified (although this can very well change playback), which indicates that probably not a lot of thoughts have been put into this display.

Quote
It's very useful in Modern tempo mode, at least to remind you of the current time signature
But then again, there are also pattern highlights, which do exactly the same thing.

Quote
Perhaps make it so that it always displays the current time sig (and not only when playing).

Now with that new feature, this is even more difficult than it already was.

Quote
Btw, what I would use in the main toolbar is a TAP button to set the bpm with mouse clicks.
You mean like the spin buttons next to the tempo control?
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Paul Legovitch

  • Workaholic artist
  • ***
  • Posts: 145
    • http://legovitch.blogspot.com
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #11 on: August 02, 2010, 23:10:34 »
Quote from: "Jojo"
But then again, there are also pattern highlights, which do exactly the same thing.

You mean secondary highlights, I always uncheck this : the pattern has too much stripes with these, thus I need to see this value.
Now, based on what you say (this element not marking the module as modified, etc), then ok I guess it's better to get rid of it. :lol:
But if possible I'd rather have these 2 values (RPB and RPM) appear in the pattern editor gui (next to pattern name and seq name perhaps), not only in the pattern properties dialog, to be able to instantly see the time signature changes when playing the song or when browsing through the patterns.
I think the default values should also appear in the general tab gui next to the tempo (btw the tempo slider seems to me like a rather useless element there).


About the TAP button :
Quote from: "Jojo"
You mean like the spin buttons next to the tempo control?

No. Every daw has this : you have a tempo in mind, you click several time in rhythm on a button (often called TAP, near the bpm value) and based on the time elapsed between two clicks, the software sets the correct bpm. Very useful.

Offline Harbinger

  • Extreme artist
  • *****
  • Posts: 1,142
  • Gender: Male
  • Operating System: Windows XP
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #12 on: August 04, 2010, 22:05:03 »
Quote from: "Jojo"
Hmm.. I'm not quite sure what to do with that Rows per Beat edit control in the main toolbar. It seems so useless to me and it doesn't make much sense to use this together with per-pattern time signatures. Does anyone actually use this feature?


As i was writing up the Main Toolbar in the help manual, i also wondered about this. Since you can't change the tempo permanently either with that control, i would just as soon implement a less obtrusive control, or make it optionable. :?

Offline Skaven

  • Workaholic artist
  • ***
  • Posts: 112
    • http://www.mikseri.net/skaven
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #13 on: August 08, 2010, 13:36:50 »
Quote from: "Jojo"
This is working better than expected... The engine was already well prepared for such a feature.


Whoops! Forgot to check back here. But what I see up there looks awesome!  :welldone:

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,772
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
[ACCEPTED] Custom per pattern timesig / row highlight
« Reply #14 on: August 08, 2010, 13:43:10 »
Quote from: "Skaven"
Whoops! Forgot to check back here.

Well, did you have fun at ASM at least? :lol:
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.