Non-declaration of variables for MIDI Import

[Harbinger]

In my translations, i have found that two variables -- gnMidiImportSpeed and gnMidiPatternLen -- were assigned values in MainFrm.cpp but were not declared in MainFrm.h (or in the preceding lines in the .cpp).

Could this be a source of our import problems, or is this just bad form?

[Saga Musix]

MainFrm.cpp says:

Code: [Select]

extern UINT gnMidiImportSpeed;That means "This variable is not declared in this module or in any included file, please look somewhere else". Not declaring variables is impossible in C(++) for a very good reason.
Those variables are actually declared in load_mid.cpp. The way they are declared (globally, not assigned to a class) makes me shiver a bit, though...