Author Topic: 1.17.03.02 sustainloop errors in mod, s3m  (Read 2328 times)

Offline Harbinger

  • Extreme artist
  • *****
  • Posts: 1,141
  • Gender: Male
  • Operating System: Windows XP
1.17.03.02 sustainloop errors in mod, s3m
« on: October 28, 2009, 18:49:49 »
Full Version:
OpenMPT v1.17.3.02

Has the bug occured in previous versions? If yes, please specify version(s): Don't think so.

Description of the bug: When a Sustain Loop is set for a sample in an XM or IT (or IT-type) track, and then the track is converted to MOD or S3M, the Sustain Loop is remembered but disabled (we want this), but the loop is still played. Sustain loops should be ignored outright in converted tracks.
The Sustain loop is not remembered at save time, so that works properly. But IMHO you shouldn't have to save, close, and open the file in order to do conversion/comparison tracking between MOD/S3M and XM/IT.

How often does it happen?:
Always.

How to reproduce (step by step description):
Create or open an XM or IT track.
Load a sample and set its Sustain Loop.
Go to Song Properties and switch the track type to MOD.
Go back to the Samples page and see that the Sustain Loop is still present but the parameter settings are grayed out. Previewing the sample still loops within the Sustain Loop.

edit by mod: Added description in topictitle

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,677
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
1.17.03.02 sustainloop errors in mod, s3m
« Reply #1 on: October 29, 2009, 22:01:12 »
Thanks, sustain loops should be removed of course.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,677
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
1.17.03.02 sustainloop errors in mod, s3m
« Reply #2 on: January 25, 2010, 22:22:23 »
Please confirm that this has been fixed in OpenMPT 1.18 release candidate. You can set the thread status to S=C yourself then.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.