Author Topic: .47 Bad pattern scrolling when clicking  (Read 5542 times)

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,652
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
.47 Bad pattern scrolling when clicking
« on: May 13, 2007, 12:07:29 »
Ensuring that cursor is visible works, but i found a new strange behaviour.
I think that's the way it happens.
1) Set cursor position to 1st channel.
2) Scroll to the last channel (e.g. channel 32) without moving the cursor
3) click a channel that is visible
4) now the pattern scrolls, although it's not necessary.

Edit by rewbs: topic should describe the bug.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline rewbs

  • OpenMPT Developers
  • *****
  • Posts: 578
.47 Bad pattern scrolling when clicking
« Reply #1 on: May 13, 2007, 13:05:54 »
I don't understand step 3.
Edit: sorry I get it now  - reproduced and bug description clarified.

Offline rewbs

  • OpenMPT Developers
  • *****
  • Posts: 578
.47 Bad pattern scrolling when clicking
« Reply #2 on: May 13, 2007, 13:44:28 »
The problem is the separate consecutive calls to SetCurrentRow() and SetCurrentColumn() that occur when the pattern editor is clicked.
If the cursor is off-screen when the click occurs, SetCurrentRow() will result in scrolling back to the cursor's original column. Then, the call to SetCurrentColumn() causes another scroll to restore the visibility of the new column position.

Offline pelya

  • Workaholic artist
  • ***
  • Posts: 108
Fix
« Reply #3 on: May 13, 2007, 15:48:36 »
Since that was my bugfix  :oops:  I've posted patch against that new bug introduced.

--- Yay, my first patch is committed! I'll set some avatar picture to celebrate it  8) .

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,652
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
.47 Bad pattern scrolling when clicking
« Reply #4 on: May 16, 2007, 17:43:50 »
okay, there's another strange behaviour which seems pretty the same: if i set the cursor to channel 1 and scroll again to the last channel, it automaticly scrolls back to channel 1. that's annoying if you just want to see "what' going on over there" - at the other channels.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline rewbs

  • OpenMPT Developers
  • *****
  • Posts: 578
.47 Bad pattern scrolling when clicking
« Reply #5 on: May 16, 2007, 20:30:22 »
Jojo, I'm guessing you have Follow Song on?

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,652
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
.47 Bad pattern scrolling when clicking
« Reply #6 on: May 16, 2007, 23:18:17 »
yes. i need it. :) and this new behavious is quite annoying. one should be able to turn it off.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline rewbs

  • OpenMPT Developers
  • *****
  • Posts: 578
.47 Bad pattern scrolling when clicking
« Reply #7 on: May 27, 2007, 20:33:04 »
Please try v1.17.02.48.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,652
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
.47 Bad pattern scrolling when clicking
« Reply #8 on: May 27, 2007, 21:11:27 »
i'm sorry but the site looks kinda broken to me - coz I can't see any download links anymore for the relaeses - just the changelogs! also, the table header says "OpenMPT dev build v ()" i think a version is missing here. seems like something went wrong over there.

EDIT: I got the file using the RSS feed now, let's see if it works! ;)
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,652
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 10 x64
.47 Bad pattern scrolling when clicking
« Reply #9 on: May 27, 2007, 21:28:58 »
okay, it works in .48 - my day is saved! it was a pain to do large tracks (like Grinimal) with this bug - again, thanks for the good work!
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.