1.18.03.00 Loop value produce a change to sample

[Zenon]

Full Version:
OpenMPT v1.18.00.??

Has the bug occured in previous versions? If yes, please specify version(s): (This option is optional, and doesn't need research. But in case you know...)


Description of the bug:
A sample in .mod result modified with some loop values

How often does it happen?:
always

How to reproduce (step by step description):
I have noticied with a mod of mine.
just set the loop to certain values (322 - 3036), save the mod, reopen it and
you'll see the sample sine is modified.

[Saga Musix]

Can you please be a bit more precise? Your bug report can mean anything. Note that the MOD format only supports 8-bit samples, so if you work with 16-bit samples, they will of course look different after loading the MOD file again.

[Zenon]

All samples are 8 bit , 8363Mhz.

I put the mod file on my site, so this is how reproduce the fact:

download the file here.

Then, go to the sample number 3 (SWL-JX15), and put these values on the sample:

Start   322
End   3036

save, and reopen the file.
Now sample looks changed.

[Saga Musix]

Right, the post-loop part is adjusted to fit the loop start when loading MOD and S3M files. I'm not quite sure why that happens with MOD/S3M only, but I'll look into it. Normally you don't notice this change anyway, because you should trim the sample after the loop end.