1.18.03.00 Cleanup error with multiple sequences

Started by Skaven, September 05, 2010, 19:02:12

Previous topic - Next topic
Print
Go Down Pages1
User actions

Skaven

September 05, 2010, 19:02:12 Last Edit: November 20, 2010, 22:17:16 by Jojo
Full Version:
OpenMPT v1.18.00.03

Description of the bug:
The Cleanup:  rearrange / remove unused patterns function (from the Edit menu) doesn't work properly with a .mptm song that has multiple sequences in it.

How often does it happen?:
(every time)

How to reproduce (step by step description):
- Open a tracker song with multiple sequences. Make sure it has some unused patterns, and that they are in an order that requires rearranging
- Use the Cleanup function from the Edit menu, and check the appropriate functions  (Patterns: Remove Unused + Rearrange)

The patterns get re-arranged in all the sequences in a messed up fashion. Pattern #00 gets inserted in the start of every sequence. The patterns are not rearranged in order of appearance.

Saga Musix

#1
September 05, 2010, 23:11:25
Doh! Well that was an embarassing one, but it should be fixed now.
Test build (as always): http://sagagames.de/stuff/mptrack.exe
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Skaven

#2
September 06, 2010, 03:47:32
Wow, that was quick! :D  Thanks!

Saga Musix

#3
September 06, 2010, 10:41:26
Quote from: "Skaven"Wow, that was quick!
Well, it was a matter of moving one line of code to another place... Luckily. :) I would not have wanted to rewrite that whole reordering code. :lol:
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.
Print
Go Up Pages1
User actions