.48 Bxx + Loop Pattern doesn't work as expected

Saga Musix · June 30, 2007, 22:34:56

Full Version:
OpenMPT v1.17.02.48

Has the bug occured in previous versions? If yes, please specify version(s): (This option is optional, and doesn't need research. But in case you know...)
Didn't happen in original MPT and OpenMPT build .45 (same configuration as .48 )

Description of the bug:
If you are in "loop pattern" mode and there is a Bxx command, MPT will jump to the specified pattern. That should not happen. Everything works okay with the Cxx (skip to row XX in next pattern) effect, it will stay in the same pattern, as expected!

How often does it happen?:
Always

How to reproduce (step by step description):
Create some empty patterns. put a B00 effect in one of the patterns. press play, skip to that pattern and turn on "loop pattern". you'll see that openMPT will skip back to pattern 0.

Edit: Moved to the issue tracker: http://bugs.openmpt.org/view.php?id=15

Sam_Zen · June 30, 2007, 23:52:55

I wouldn't know about previous versions, because I hardly used this.
But confirmed. Checked with XM-format.
And I agree, that this is quite illogical behaviour.

Relabsoluness · July 01, 2007, 22:48:38

This one is also a result of a bug fix which caused behavior change. Yes I agree that it's better not to change these behaviors, but I disagree that this behavior is somehow less logical - almost on the contrary: pattern loop having any effect on C__ or B__ seems somewhat illogical: I don't see Pattern loop being the same as 'lock playback to this order/pattern regardless of modeffects'.

Sam_Zen · July 01, 2007, 23:07:51

You've convinced me. A better point of view actually.

Saga Musix · July 02, 2007, 12:46:18

But not me

In fact, i often loop my patterns several times to ensure that i put every single note correctly. and i guess you CAN imagine how nerv-wrecking it is when the tracker leaves my patterns... :evil:

LPChip · July 21, 2009, 10:37:38

What are we going to do with this bug?

We either should have a discussion on what we want as behavor and make a decision based on its outcome, or we should decide what to do with the bug as is...

Saga Musix · July 21, 2009, 10:45:02

Well, two devs with different opinions... Now this could lead to a commit war, but I'm not that evil.

Harbinger · February 23, 2010, 21:04:03

Perhaps there should be an option to do one or the other of these behaviors based on the setting of Loop Pattern.

Anywho, i have to address this in the OHM....let us know.

Saga Musix · February 23, 2010, 21:23:10

Well, there's not much reason for the new behaviour, apart from that it fixes a very weird behaviour of the playing engine that I have not been able to fix yet.