ModPlug Central

OpenMPT => Development Corner => Topic started by: sunshine on February 08, 2020, 20:48:00

Title: Open ModPlug Player
Post by: sunshine on February 08, 2020, 20:48:00
Hello,
I have been developing Open ModPlug Player, and I want to contribute my code to ModPlug Central, and I want my project to be a part of Open MPT. I also want to be a contributor of Open ModPlug Tracker & Player.

Can you please accept my contribution?

Open ModPlug Player is based on LibOpenMPT, Qt, PortAudio, and supports Windows, macOS and Linux natively. It is currently in alpha stage, but 40% of its development was done.

By the way, I am planning to add spectrum analyzer this week.
Title: Re: Open ModPlug Player
Post by: Saga Musix on February 09, 2020, 20:37:10
Hi there,
Quite frankly, your wish is the exact opposite of our current development intentions. libopenmpt currently comes with several player plugins in its source tree, but the additional development burden is just too much for us, so we intend to give them back to the community where possible (as already happened with the Foobar2000 plugin, which is now officially maintained by kode54). Having even more software built on top of libopenmpt in our code repository would thus just contradict of our long-term goal.

Of course you are welcome to submit patches to OpenMPT / libopenmpt and contribute to its development, but I'm afraid that we cannot have yet another player in our code repository. You are of course welcome to develop your player outside of the OpenMPT repository  like all the other players using libopenmpt (https://wiki.openmpt.org/Libopenmpt#Software_using_libopenmpt) (and of course we can add your player to this list once it's public), but I would prefer if you chose a different name to not give the impression that it is an officially endorsed or OpenMPT-derived software.
Title: Re: Open ModPlug Player
Post by: sunshine on February 09, 2020, 20:42:01
Thanks for the information Saga Musix. Can I use "ModPlug Player" name and the graphical design of original ModPlug Player for my player? I already have a code repository on GitHub, and I am planning to make all the codes public when my application becomes to beta phase.
Title: Re: Open ModPlug Player
Post by: Saga Musix on February 09, 2020, 21:25:14
You would have to ask Olivier (the original author) about that, I guess, however I don't think that choosing the same name as an existing software is going to make the situation any better for anyone. MPP in particular doesn't have a good reputation for this playback quality these days (which makes sense given that it as last updated almost 20 years ago), and you would just taint your own software with this reputation if you were giving it the same name. Why not use a completely different name?

On an unrelated note, I see you are trying to make an exact copy of the original MPP but I think many of the options present there are outdated or simply not useful. A modern player probably doesn't need any bit depth configuration and no option to configure the amount of buffers. The "headphones" option also doesn't make a lot of sense since the particular code path that was used for this in MPP isn't even exposed by libopenmpt (it changed the way panning works).
Title: Re: Open ModPlug Player
Post by: sunshine on February 09, 2020, 21:53:45
Thank you very very much for your precious comments and recommendations Saga Musix. You are right so much. I also consider to implement a skinning feature.  It would be better to design a completely new Module Player application. It will also have some new features like scope display.
An exact copy of a very old application is not a good idea :)

If I can have some more spare time, I will want to take a part on the development of OpenMPT software in the future.
Title: Re: Open ModPlug Player
Post by: sunshine on May 16, 2020, 18:53:14
I implemented spectrum analyzer and vu-meter for my new module player. If I could get a permission to use original design of ModPlug Player, it would be very nice. At least there might be a choice to show old GUI, and it can be selectable on the preferences window.

Screenshot of my latest work is here.
Title: Re: Open ModPlug Player
Post by: Saga Musix on May 16, 2020, 19:31:07
Well, as said, you will have to ask Olivier for permission, we cannot grant it. We don't even have the source code for the original player. However, since you basically just recreate the approximate location of every button, and are not even making a pixle-perfect copy, I don't see a technical need for asking for permission.
Title: Re: Open ModPlug Player
Post by: sunshine on May 16, 2020, 19:47:54
Thank you very much for the information Saga Musix.
Yes, it will not be pixel-perfect copy of the ModPlug Player, and I will improve the design in the future. For example, I may remove option buttons on the right side because we will not need most of them, and some functionality of that buttons can be moved to the right-click menu, and on the mac to the application menu appearing on the top of the screen. In place of that buttons, I may add a horizontal vu-meter or I may think something different.

As you said, this module player will have so many differences from the original ModPlug Player, probably it will not be any problem to continue to mimic the design of the original ModPlug Player.

I want to ask Olivier Lapicque to use the name of "ModPlug Player" and to mimic the design of the original ModPlug Player. If I will not be allowed, I will use a different name and a little bit different design for my new module player.

Can I write an e-mail to olivier@modplug.com to ask Olivier Lapicque? Is this mail address still accessible?
Title: Re: Open ModPlug Player
Post by: Saga Musix on May 16, 2020, 20:13:54
I'm rather sure that email address does not exist anymore (Olivier does not run modplug.com), but I also cannot give you any other up-to-date contact information. I was never in contact with him. Supposedly this is his LinkedIn profile (https://www.linkedin.com/in/olivierl), maybe you can contact him that way.
Title: Re: Open ModPlug Player
Post by: sunshine on May 16, 2020, 20:21:12
Thank you very much Saga Musix. I will release first final version of this application next year because there are a lot of things to do like spectrum analyzer bars falling with acceleration, preferences window and perhaps uade123 integration. Until the first release or maybe beta version, I will try to contact Olivier Lapicque. I tried to add him to my Linked-In network in the past, but he didn't add me (probably because he doesn't know me or he adds only the persons he is familiar with).
Cheers
Title: Re: Open ModPlug Player
Post by: Exhale on May 17, 2020, 11:15:58
How about calling it boombox Modplug?
Title: Re: Open ModPlug Player
Post by: sunshine on May 17, 2020, 11:38:43
Perhaps we can find a much better name together with everybody here. I may create a new topic for the name of the new module player. I consider to do these things after then releasing first beta version of the new player.
Title: Re: Open ModPlug Player
Post by: sunshine on May 26, 2020, 18:08:25
Olivier Lapicque allowed me to use the name and the design of the ModPlug Player. Probably I will release first alpha version of ModPlug Player 2.0 in a few months for Windows, macOS and Linux. We will have first final version in 2021, and mobile version of ModPlug Player next year.
Title: Re: Open ModPlug Player
Post by: ASIKWUSpulse on May 27, 2020, 18:10:22
Oh you're making it an mobile app too? Yes please!
Of what I know, there's only 2 module-players for phone (android) - xmp and another one that can only play the MOD-format (can't remember it's name)
xmp has really slow development rate and is super light, nearly in an inconvenient way - i.e. loop can only be turned on (loop infinitely) or off
But its module-playback core is excellent (has support for a lot of module-formats) and it has nice visuals that happens to be the ones like channel-oscilloscopes and channel-status, that ftm of what I've heard of the OpenMPT dev is hard to accomplish with the OpenMPT API, due to the tricky module-playback core. Hopefully that will be easier in the future since the developers here are doing a great job on the progress of OpenMPT :).

Though it really would be nice to have something like xmplay for mobile too, when you want to bring module-music with you. mo3 and compressed stuff would be a hot support-need for the mobile version, since mobiles are still like the 90's home computers in storage (at least mine is - only like 16 GB of free internal space + an SD-card adding an extra 14 GB)
Title: Re: Open ModPlug Player
Post by: sunshine on May 27, 2020, 18:27:54
Yes, I am planning a mobile version, too. Its user interface will be very similar to desktop version of ModPlug Player. It will work in landscape mode on the cell phones and tablets. I am not sure to support portrait mode.
Title: Re: Open ModPlug Player
Post by: sunshine on June 18, 2020, 19:39:52
Some settings have been added to setup window, and most of them are functional. When I find free time, I update the ModPlug Player constantly.
I also got the domain http://www.modplugplayer.org and it will be opened in a few months. I am planning to release first alpha version in a few months.
Title: Re: Open ModPlug Player
Post by: Saga Musix on June 19, 2020, 18:33:34
I suggest you don't spend effort on designing any settings pages before you actually need them. As mentioned before, most of the audio related settings don't make any sense in a modern audio player. You can expect to be able to output floating-point audio pretty much anywhere, and you certainly don't need to specify a number of buffers to keep with any modern cross-platform audio library. The only settings that really make sense are the device itself, sampling rate (which should default to 48 kHz because that's what every audio hardware is running at these days), buffer length and maybe number of channels (stereo/quad, if someone wants mono they can use the stereo separation slider).

Personal opinion: I wouldn't use a pure module-only player in 2020. In fact, I switched away from ModPlug Player to Winamp in 2005 or 2006 and eventually to XMPlay in 2007, I think. Being able to play both modules and streamed formats without having to switch software is just extremely convenient. If I were you, I'd try to at least support all common streamed music formats (MP3, Vorbis, Opus, FLAC) as well.
Title: Re: Open ModPlug Player
Post by: sunshine on June 20, 2020, 07:00:26
Thanks a lot for your precious suggestions Saga Musix. I do the things you mentioned on your first paragraph, I am taking note.

I am developing ModPlug Player for nostalgic reasons, and I want to make it live forever :) I can't open its source codes for a few years, because of my spectrum analyzer codes, I am planning to use it on some VST plugins that I will develop commercially, but I am planning to open its source codes a few years later, and every contribution will be welcomed. If you accept that time, it may be a part of the ModPlug software, but if you still don't want that time, it will be a separated project.

I have a plan to develop a multi-platform player like WinAmp, and it will be able to use WinAmp's modern skins (or I may consider something else for legal things). Because I want ModPlug Player much more than WinAmp, I wanted to develop ModPlug Player firstly.
Title: Re: Open ModPlug Player
Post by: sunshine on June 20, 2020, 07:13:22
By the way, I am planning to support MIDI formats (*.mid, *.rmi), UADE formats (by integrating uade123 library to ModPlug Player for old game musics), and perhaps cmf and adlib formats. For MIDI formats, I am planning to use FluidSynth library. I will add Sound-Font selection page to settings window. I may improve Sound-Font selection system in the future.
I may also support Roland MT-32 emulation.

Since I am planning to develop also a media player like WinAmp in the future in addition to ModPlug Player, I don't plan to support streamed music formats in ModPlug Player.
Title: Re: Open ModPlug Player
Post by: manx on June 20, 2020, 07:33:24
Well, if you are going to support all kinds of file formats and backends anyway, I think choosing a name of one particular playback engine as the name for the whole player is a rather bad choice.

Also, if the source code is not public, calling it "Open" is misleading, in my opinion.
Title: Re: Open ModPlug Player
Post by: sunshine on June 20, 2020, 07:38:38
Its name is not "Open ModPlug Player". Its name is "ModPlug Player". I may not support MIDI, cmf, etc., I don't have a plan for these formats currently. I may support these plugins by input plugins, and name of "ModPlug Player" may remain meaningful. Making it open source will take a few years, just because of my spectrum analyzer. Perhaps I may simplify the spectrum analyzer and make it open source in a short time. My current spectrum analyzer is very parametric and it is suitable to use in VST plugins.
Title: Re: Open ModPlug Player
Post by: sunshine on June 20, 2020, 07:49:30
You are right manx, perhaps I sohuld support only ModPlug formats, because its name and design are Modplug Player's name and design. I may support other formats on a different player, but ModPlug Player should remain as ModPlug Player.
Title: Re: Open ModPlug Player
Post by: sunshine on June 20, 2020, 17:05:28
https://youtu.be/PvI360eGGn0

A short video of the current state. I will also add falling and raising animations for spectrum analyzer on next months.
Title: Re: Open ModPlug Player
Post by: sunshine on June 21, 2020, 22:22:32

I consider to make button light border colors selectable also. After then adding spectrum analyzer falling and raising animations, I am planning to make a web site for ModPlug Player, and its address will be http://www.modplugplayer.org

Saga Musix, manx and everybody else, please write all your comments to make this player better.
Title: Re: Open ModPlug Player
Post by: sunshine on October 30, 2021, 14:15:24
Development of ModPlug Player 2.0 still continues. Many things will be parametric. Its web site and first beta version will be released in 2022.
Title: Re: Open ModPlug Player
Post by: mabersold on November 08, 2021, 17:00:13
Is it multi-platform?
Title: Re: Open ModPlug Player
Post by: sunshine on November 08, 2021, 17:03:19
Yes, there will be Linux, macOS and Windows versions. Starting from first beta version it will be multi-platform.
Title: Re: Open ModPlug Player
Post by: GeorgeDoesStuff on December 21, 2021, 18:13:03
Where is the website? I can't seem to be able to access it.
Title: Re: Open ModPlug Player
Post by: sunshine on December 21, 2021, 19:43:39
I haven't prepared the website yet. I will prepare it after then releasing the ModPlug Player.
I developed some new technologies for ModPlug Player, and I am planning to release it using GPL license but I don't have enough knowledge related to GPL.
After then learning how to patent new technologies using GPL, I am planning to release ModPlug Player as open source.
Title: Re: Open ModPlug Player
Post by: Saga Musix on December 21, 2021, 20:12:32
If you patent something and then release it under the GPL, you effectively give anyone the right to do with that patent whatever they want (as long as they do it under the GPL at least). And that of course completely disregards that software as such cannot be patented in the EU for example (Turkey seems to be very similar (https://www.lexology.com/library/detail.aspx?g=c2c8e361-69b5-4b51-b7ea-8422335c5dab) regarding patentability of software and mathematical methods / algorithms); and that there is probably nothing novel left worth patenting in an audio player these days anyway, especially one that intends to be a clone of an existing piece of software.
Title: Re: Open ModPlug Player
Post by: sunshine on December 21, 2021, 20:17:52
Thanks for the information @Saga Musix. I want to patent all the technologies I developed under the GPL. I will need to do some patent research to be sure that these technologies were not developed in the past.
The reason why ModPlug Player is delayed so much is the new technologies I developed. After then making this subject clear, I am planning to make ModPlug Player completely open source.
Title: Re: Open ModPlug Player
Post by: sunshine on December 21, 2021, 20:26:45
The most important thing is that I don't want anybody to take a proprietary patent for a technology that I developed. I want all the technologies I developed remain under GPL. I need more information for this case.
Title: Re: Open ModPlug Player
Post by: Saga Musix on December 21, 2021, 20:35:04
Again, algorithms cannot simply be patented (in the EU and your home country). A patent isn't even valid world-wide automatically, achieving that is a long and expensive process. It's essentially futile for a single person.
If you simply release something under the GPL, that automatically means that noone can take it and use it in their proprietary software, because it's a "viral" license (the derivative work must be released under the GPL as well). You don't need a patent for that. However, someone can of course still come up with the same algorithm independently without ever having seen your code and use it in their software (and I see that as a good thing). This is in fact one of the reasons why software patents, as they are possible in the US, are so stupid and rather harmful to the whole programming community: Lots of trivial and obvious algorithms have been patented in the US, which means that you either have to pay silly amounts of money to the patent owners, or you have to work around the problem by coming up with a different way of solving the problem, even though you have maybe never seen the work of the patent holder in the first place.
Just search for "patent" in this collection of coding hacks for example to see the damage software patents can create: https://graphics.stanford.edu/~seander/bithacks.html
Title: Re: Open ModPlug Player
Post by: sunshine on December 21, 2021, 20:43:00
I want to protect especially my new designs under the GPL. I mean that I don't want anybody to take a proprietary license for my designs. If I release ModPlug Player source code, and add License.txt file of GPL, will all my designs be licensed under the GPL automatically?
Title: Re: Open ModPlug Player
Post by: Saga Musix on December 21, 2021, 20:45:35
Yes, although to be extra safe you should add a notice in the header of every source file (e.g. using a verbatim copy of the license or by adding a SPDX (https://en.wikipedia.org/wiki/Software_Package_Data_Exchange) license header).
Title: Re: Open ModPlug Player
Post by: sunshine on December 21, 2021, 20:46:49
Thank you very much for the information Saga Musix.
Title: Re: Open ModPlug Player
Post by: sunshine on December 22, 2021, 16:01:09
Source codes of new ModPlug Player will be released before the year 2022.
GitHub page of ModPlug Player is https://github.com/ModPlugPlayer
Title: Re: Open ModPlug Player
Post by: sunshine on December 22, 2021, 16:50:30
ModPlug Player's license is GPL 3.0
All the libraries of the ModPlug Player (except for 3rd party libraries) are LGPL 2.1
Source codes of all the libraries can be accessed as like ModPlug Player from https://github.com/ModPlugPlayer
Probably tomorrow all of them will be able to be accessed.
Title: Re: Open ModPlug Player
Post by: sunshine on December 22, 2021, 23:48:03
Some screenshots of the latest version of ModPlug Player. Please always write your comments.
Color selections for spectrum analyzer and vu meter can be done using gradient bar as it seems on the screenshot. Unlimited amount of color markers can be added and every color marker can be removed.
Title: Re: Open ModPlug Player
Post by: sunshine on December 22, 2021, 23:54:58
Some other screenshots
Title: Re: Open ModPlug Player
Post by: sunshine on December 22, 2021, 23:58:27
Spectrum analyzer and vu meter can do free-fall movements on both upwards and downwards. Peak markers also are able to do free-fall movements.
Title: Re: Open ModPlug Player
Post by: sunshine on December 23, 2021, 12:52:49
ModPlug Player is open source now. All of its components are pushed to GitHub.
You can access to the source codes from https://github.com/ModPlugPlayer
Title: Re: Open ModPlug Player
Post by: Newbie on December 24, 2021, 20:18:59
Are there any compiled Windows binaries of Open ModPlug Player or is this only for Mac? I see the root folder only has an icns icon file not an Windows ico.
Title: Re: Open ModPlug Player
Post by: sunshine on December 25, 2021, 05:29:03
ModPlug Player 2.0 is multi-platform. I am currently working for https://www.modplugplayer.org web site. In a few weeks, compiled binaries for Windows and macOS will be able to be downloaded from the web site.
Windows version uses images from MPP.iconset (I remember so, but I may do somethings for Windows version). I will arrange folder structure in the future, but there are a lot of things to do for now before that.
Yesterday I also prepared my Windows environment to prepare Windows binaries.
Windows version is compiled on MSYS2 environment and needs pkg-config package to be installed on MSYS2. Last time I compiled ModPlug Player for Windows was previous year, and so many things have changed. Even if you compile ModPlug Player on Windows right now, it may not work and seem correctly. Therefore, in a few week the web site and compiled Windows binaries will be ready.
Since it is compiled on MSYS2 environment on Windows, it doesn't need ico file for Windows, but I will also prepare an ico file, too, in the future for Visual Studio compatibility. However., Visual Studio compatibility is not soon so much.
The same things are also valid for Linux version. Previous year I compiled ModPlug Player on Linux, too, but so many things have changed. I will need to do some rework for Windows and Linux compatibility, but it will not take so much time.
Title: Re: Open ModPlug Player
Post by: StarWolf3000 on December 25, 2021, 11:15:44
Since you're hosting the source code on Github, you could set up Github Actions to trigger builds for all platforms (don't know if that would work for mac though) upon submitting a commit or PR.
Title: Re: Open ModPlug Player
Post by: sunshine on December 25, 2021, 11:23:48
It requires some build configurations on GitHub. In the future I may make the project compatible with build automation.
By the way, I will also provide with instructions to build ModPlug Player from its source codes for each platform in the future.
There will also be Debian and Ubuntu packages in the future.
Title: Re: Open ModPlug Player
Post by: sunshine on December 26, 2021, 23:11:21
I compiled it on Linux with some small fixes, and I will do some small GUI arrangements. For example, hiding the native titlebar, adding buttons for closing and minimizing the application, adding a beautiful font for the GUI, etc.
On Windows, I am still working to compile it.
In short, all versions (Windows, Debian, Ubuntu, KDE Neon Linux and macOS) will seem very similar (with some native differences on preferences windows, but not on the player window).
Title: Re: Open ModPlug Player
Post by: Jazztache on December 26, 2021, 23:45:18
Are there any plans to add a per-channel oscilloscope view like the one in MilkyTracker?
Title: Re: Open ModPlug Player
Post by: sunshine on December 27, 2021, 06:10:35
Yes, it will be like on ProTracker. When spectrum analyzer is clicked, it will be multi-channel oscilloscope.
Window function will also be selectable for oscilloscope and spectrum analyzer as it seems on the second screenshot below.
I am also planning to add ProTracker mode for spectrum analyzer. ProTracker doesn't do any frequency analysis on its spectrum analyzer, instead, it shows bar heights based on the played note.
Title: Re: Open ModPlug Player
Post by: Saga Musix on December 27, 2021, 12:03:38
That's quite a promise to make given that libopenmpt doesn't currently offer per-channel waveform data at all. It is planned to have that one day, sure, but it simply doesn't exist at this point in time.
Title: Re: Open ModPlug Player
Post by: sunshine on December 27, 2021, 13:05:22
Thanks for the information Saga Musix. I didn't know libopenmpt doesn't support this feature yet. I may add oscilloscope feature after libopenmpt supports this fuature. Let it be our feature wish for libopenmpt  :)
Title: Re: Open ModPlug Player
Post by: sunshine on December 27, 2021, 18:13:57
macOS version of ModPlug Player 2 Alpha 1 can be downloaded from
https://sourceforge.net/projects/modplugplayer/files
Please notice that this is an alpha version, many features and settings don't work correctly.
Title: Re: Open ModPlug Player
Post by: sunshine on January 03, 2022, 15:36:37
ModPlug Player can now be compiled on Windows, too. After then some arrangements, Windows and Linux binaries will be downloadable.
Title: Re: Open ModPlug Player
Post by: sunshine on January 05, 2022, 20:05:33
After then titlebar buttons (minimize, close and mini player buttons) are added, Windows and Linux versions will be ready. Latest screenshot of Windows version is below.
Title: Re: Open ModPlug Player
Post by: sunshine on January 07, 2022, 20:01:31
Windows version of ModPlug Player 2 Alpha 1 can be downloaded from https://sourceforge.net/projects/modplugplayer/files
You may need to configure color settings of ModPlug Player on the first use (since it is alpha version yet).
Title: Re: Open ModPlug Player
Post by: Newbie on January 08, 2022, 15:25:41
Open ModPlug Player for Windows loads but everyttime I load it it is a different color and the text labels are un readable because they are the same color as the ui
Title: Re: Open ModPlug Player
Post by: sunshine on January 08, 2022, 16:32:10
You should do your color configuration once (the color configuration window seems on the screenshot below). The default color values currently doesn't work, so configurations should be done by the user for the first time.
Title: Re: Open ModPlug Player
Post by: sunshine on January 09, 2022, 14:19:25
ModPlugPlayer can also be compiled on Linux, too. Linux version has "ALSA lib pcm.c:8526:(snd_pcm_recover) underrun occurred" errors when playing for a few seconds, this causes skipping a few seconds of the module. This problem will be solved on one of the next alpha versions.
You can compile ModPlugPlayer on Linux by reading ModPlugPlayerLinux.txt file (look at the attachments of this message). I am using KDE Neon Linux distro, but any Debian or Ubuntu based Linux distro will work, too.

Edit: Editing /etc/pulse/daemon.conf file and modifying the lines as like below, then restarting the computer solves the buffer underrun problem. On the next versions I will research it for programmatic solution.
Quote
default-fragments = 5
default-fragment-size-msec = 2
Title: Re: Open ModPlug Player
Post by: Merlyn6175 on January 10, 2022, 21:54:55
Excellent work, still use the original ModPlug Player, but now there a new version to try.

Looks good so far, once I've set the colours.

I know its in the test stages but I've noticed I cant set the mixing rate or bit rate, It always goes back to 16bit 44.1khz and I cant move the window. ( windows 10 )
I'll will test it  tomorrow when I have more time.
Don't forget to add .C67 file types to the load box . just tested the original Amnesia demos CDFM tracks  and they work. wasn't sure if the Adlib tracks would show on the spectrum analyser but they did.

looking forward to your next update.
Title: Re: Open ModPlug Player
Post by: Exhale on January 11, 2022, 01:35:51
I agree, it is great to see good old modplug player back in action. I did a test - made a pair of .it files quick, one with a direct x effect on and one without just to test and it played them both correctly as they would play in ompt :)

a thought though - when I installed, the entire thing was red and I had no clue what buttons did what (it has been a bunch of years), eventually I found the settings and changed the colours... and of corse most of the buttons dont work. Either way it is great to see the old boy kicking again and I am very much looking forward to the first official release. Do you have any plans on if MPP is going to check the computer for installs of OMPT and then reference it for any more complex vsts? because that would be insanely awesome, but even without that I could see myself getting into sticking to the direct x effects as a challange and making a playlist for it personally :)
I would suggest a system that remembers the last folder you opened on the computer so you dont have to go through the file tree every time you want to get a tune, and also I wonder if you plan on adding mptm as a possible file time to be played within.

Great work, good luck, and I hope you are having a good time making it.
Title: Re: Open ModPlug Player
Post by: sunshine on January 11, 2022, 04:17:27
It is very nice to see your nice comments dear friends. I am planning to add VST effects support on plugins section of ModPlug Player. After then releasing the first final version and adding oscilloscope display, I am planning to support VST effect plugins instead of MPP's internal DSP section.
Perhaps I may replace DSP section with VST effect selection section (its name will still remain DSP) and multiple DSP plugins will be able to be selected and their order will be able to be specified. I may also replace one button of ModPlug Player with Equalizer button (maybe either Delete, Clear or Remove button), and that button will bring the specified VST effect plugin window (such as API 560 Equalizer) to the screen. Eq button specification will be made on the DSP section of "ModPlug Player Setup" window.
I may do these modifications on one of the alpha versions of ModPlug Player as non-functional just for showing how it will be like.
Title: Re: Open ModPlug Player
Post by: sunshine on January 11, 2022, 04:24:25
I can also convert ModPlug Player's internal DSP to a VST plugin. In that case, I may release it as a standalone VST plugin and may also be used on DAW applications.
The name of the VST plugin may be "ModPlug DSP".
Title: Re: Open ModPlug Player
Post by: Saga Musix on January 11, 2022, 18:18:09
Quote from: Merlyn6175 on January 10, 2022, 21:54:55
Don't forget to add .C67 file types to the load box . just tested the original Amnesia demos CDFM tracks  and they work. wasn't sure if the Adlib tracks would show on the spectrum analyser but they did.

The player should really be using openmpt::get_supported_extensions() instead of hardcoding an extension list that will change with practically every major release of libopenmpt.
Title: Re: Open ModPlug Player
Post by: sunshine on January 12, 2022, 05:44:18
I have updated it on git repository now. Thanks Saga Musix.
Title: Re: Open ModPlug Player
Post by: sunshine on January 12, 2022, 13:52:34
Current file extension list is as like on the screenshot below. I added mod.* and nst.* at the end of the all modules and protracker modules as hardcoded (for Amiga file naming convention compatibility), and all the other extensions (including *.mod and *.nst) come from openmpt::get_supported_extensions().
Title: Re: Open ModPlug Player
Post by: sunshine on January 14, 2022, 22:44:51
ModPlug Player 2 Alpha 2 can be downloaded from https://sourceforge.net/projects/modplugplayer/files/
Changelog:
* Default colors are now loaded correctly on the first run.
* Sound output device can now be selected, but MPP should be restarted to use the selected sound device (it will be immediate on one of the next alpha versions)
* Sound interruption problem was solved.
* File extensions come from libopenmpt on file opening dialog.
* About window was arranged.
* Version info window was added, it can be accessed from about window.
Title: Re: Open ModPlug Player
Post by: Saga Musix on January 15, 2022, 12:58:28
Out of curiosity, why do you host the binaries on Sourceforge? I know their reputation is better these days than 10 years ago (when their owners did shady things with the site), but you can just create a tagged release on GitHub instead and attach the binaries there. This has the advantage that the binaries are clearly linked to a specific git commit.
Title: Re: Open ModPlug Player
Post by: sunshine on January 15, 2022, 13:56:58
I have never used GitHub's release system. Thanks for the information Saga Musix. I will use this system from now on.
Title: Re: Open ModPlug Player
Post by: Saga Musix on January 15, 2022, 14:04:37
Being able to upload a release on GitHub is completely independent of what you describe, nevertheless the whole process can be improved by using git correctly: From the looks of it you are currently manually mixing & matching the latest versions of the various git repositories, which is error-prone and makes it difficult to know what exactly is being used to build the final product. It would make much more sense if you used git submodules to vendor the various git repositories into the main repository. That way, you can specify exactly which version of which git repository is used. When you're ready to make a release, you'd create a git tag for that version, and you can then create a release on GitHub based on that tag. There's no need for all the aforementioned submodules stuff for that to work (you can attach any binaries you like, no matter if they are buildable with that git repository on its own), but it is very helpful because it allows everything to be built automatically.
Title: Re: Open ModPlug Player
Post by: sunshine on January 15, 2022, 14:11:50
I don't know how git submodule system works, so firstly I need to understand git submodules system. Step by step the automation can be done as you mentioned, but firstly I need to understand how git submodule system works, and then I will modify the project to make it compatible with git submodules system.
Thanks again for the information Saga Musix. I added binaries to the release manually on GitHub now, but I will do the configurations you mentioned. We can discuss it later when I understand the things you mentioned. I need to read some documents to understand it.
Title: Re: Open ModPlug Player
Post by: sunshine on January 17, 2022, 14:06:49
I learned git submodules, and applied submodules mechanism to ModPlug Player main project. When I change somethings on submodules, before pushing the main project, git client (I use SourceTree) asks to commit and push the changes on submodules, too. It is very handy system, thanks again for your recommendation Saga Musix.
It is also easier to prepare packages such as Debian package, and much easier for a user to clone and build the source codes.
By the way, I completed CMake build script of ModPlug Player. I will remove qmake based build scripts in the future.
I am learning preparation of github workflows.
Alpha 3 version of ModPlug Player 2 will be built automatically by GitHub workflow system, so ModPlug Player will be more open and transparent in terms of security; therefore, nobody will have to trust my computer anymore.
I am also preparing a MSYS2 package for portaudiocpp, so ModPlug Player will be able to be compiled without compiling any other library.
On all the operating systems, required packages will be installed and ModPlug Player will be cloned from the git repository (without cloning any other components of it, they are cloned automatically by git's submodules mechanism), after then installing required packages, ModPlug Player will be able to be compiled just using cmake's build command.
GitHub's workflows also support homebrew (for macOS) and MSYS2 (for Windows), so all builds (for Linux, Windows and macOS) will be done by just one workflow yml file.
Title: Re: Open ModPlug Player
Post by: sunshine on February 06, 2022, 17:30:33
From now on, ModPlug Player will be built automatically with GitHub workflows. Currently I prepared workflows for Windows and macOS versions, but I will also prepare workflows for Debian and Ubuntu packages.
Windows binaries are 3 versions now, that are UCRT64, MinGW64 and CLANG64 versions. I will also add workflows for Microsoft Visual Studio version binaries in the future. Since Microsoft released a package manager called vcpkg, it is possible to add Visual Studio support with package management.

You can download auto-generated binaries from GitHub by visiting https://github.com/ModPlugPlayer/ModPlugPlayer/releases/
Alpha2 version was also rebuilt with GitHub workflows automatically.

macOS version now has a better DMG package, it is also generated by GitHub workflows. Its screenshot is below.
I am also planning to add workflow for installer of Windows version in the future.
Title: Re: Open ModPlug Player
Post by: sunshine on February 19, 2022, 17:34:46
ModPlug Player 2 Alpha 3 release can be downloaded from https://github.com/ModPlugPlayer/ModPlugPlayer/releases/tag/Alpha3

Changelog:
Bug that causes deletion of the dropped file on the player was fixed.
Dragging by titlebar works.
Always on top, snap to viewport and keep in viewport features work.
Snapping threshold for snap to viewport feature can be modified on the setup window.
Long filenames that don't fit to the titlebar are shortened with three dots on player window's title bar.
Title: Re: Open ModPlug Player
Post by: Merlyn6175 on February 19, 2022, 19:32:38
Yes, a bit more usable on a PC now I can move the window round the screen.

I had my HDMI sound bar off at first which caused the player to crash when trying to play anything, once I switched it on all was fine. not sure of the cause. PC audio work as normal through the TV with the HDMI sound bar off.

these a little bug in the time, once a track loops to the start it jumps between 2 time. sometimes it fixes itself after a few seconds.

I think once the Playlist is added and I can switch interpolation off and change to 24bit 9600Hz it will be the only player I will use or need.

Keep up the good work.
Title: Re: Open ModPlug Player
Post by: sunshine on February 19, 2022, 19:40:19
If the player crashes when clicking the play button, please change sound output from the setup window, and set the sound output you want. I will fix this bug on the next alpha version.

Previous versions could be moved from anywhere except for titlebar, buttons and sliders. I didn't want to fix this bug because the solution would make player don't snap to the edges of the screen. This version has full implementation of snapping to the viewport and keeping inside the viewport (with full customizations).

Before playlist there are so many things to do but if playlist is more important than the other features, I can implement playlist feature. If everybody wants playlist firstly, please write here, so I will implement it as soon as possible.
Title: Re: Open ModPlug Player
Post by: sunshine on February 19, 2022, 19:44:52
Quote from: Merlyn6175 on February 19, 2022, 19:32:38
these a little bug in the time, once a track loops to the start it jumps between 2 time. sometimes it fixes itself after a few seconds.
Can you please describe this bug more clearly? How can I reproduce it? May it be related to loop of the song? It is very important to reproduce it.
If you mean the time display bug, it is a known bug, I will fix it later.

Quote from: Merlyn6175 on February 19, 2022, 19:32:38
Keep up the good work.
Thanks for your precious comments.
Title: Re: Open ModPlug Player
Post by: sunshine on February 19, 2022, 19:55:31
By the way, all the missing features will be implemented on the next alpha versions. If you want to increase the priority of a feature, please write here.
I am planning to enable color gradient selections, spectrum analyzer and vu-meter preferences on the setup window.

For project management (bug tracking, new features, etc.), I created a YouTrack project page. In the future, the bugs can be tracked from that page. Its address is https://modplugplayer.youtrack.cloud
Title: Re: Open ModPlug Player
Post by: Merlyn6175 on February 20, 2022, 09:50:25
QuoteIf you mean the time display bug, it is a known bug, I will fix it later.

sorry I didn't descried it well, its just the time display which you know about.  :)

For me personally its the Playlist and Sound resolution.
I like to load every mod/xm etc from my library, Play and carry on with my work. Having a resolution higher then the original Modplug players 16bit 48Khz would be great.

But this is your project, so do it the way makes you happy. As I will enjoy testing every release.


Title: Re: Open ModPlug Player
Post by: sunshine on February 20, 2022, 10:12:36
Quote from: Merlyn6175 on February 20, 2022, 09:50:25
QuoteIf you mean the time display bug, it is a known bug, I will fix it later.

sorry I didn't descried it well, its just the time display which you know about.  :)

For me personally its the Playlist and Sound resolution.
I like to load every mod/xm etc from my library, Play and carry on with my work. Having a resolution higher then the original Modplug players 16bit 48Khz would be great.

But this is your project, so do it the way makes you happy. As I will enjoy testing every release.

Thanks dear friend. This is not just my project, this is everybody's project, so this is also your project. All the recommendations and comments are welcome.
I am planning to remove sound card settings from ModPlug player and move sound card settings to a plug-in. I will add sound output plug-in support. Its format will not be the same as Winamp's sound output plug-in format, because its interface is written in C. ModPlug Player will support plug-in interface in C++ (and it will be portable between different compilers). Because of this plan, I postponed sound card works.
I will implement playlist feature after then spectrum analyzer and vu-meter color gradient settings works are done.

Boost's DLL library (the name of the library is DLL) supports C++ plug-in interface. I am planning to use Boost's DLL library for ModPlug Player's plug-in architecture.
Title: Re: Open ModPlug Player
Post by: sunshine on March 14, 2022, 21:43:42
PlayList editor of ModPlugPlayer is almost ready. We will have our new PlayList Editor on the new alpha version.
New features of PlayList Editor:
* Drag&drop support: Single and multiple files can be dropped to the playlist editor by dragging the files from anywhere. Drag and drop can also be done between playlist items by dragging the items by mouse. Multiple files can be selected and moved by mouse.
* Multiple selected files can be removed from the PlayList once.
* Drop indicator line is shown when dragging the files from outside of PlayList or moving the playlist items. Qt's drop indicator is buggy; therefore, I wrote drop indicator from scratch.
* PlayList can also be closed by clicking PlayList button on the player, and the LED on the player stays on while playlist is open.

I added a screenshot, but this is very early screenshot. Its view will change so much. Header arrangement will be done, more buttons will be added, buttons will be like LED buttons of the player, playlist colors will be the same as the player colors. On the screenshot, gray text represents file name (with optionally its path), black text on the gray text represents the title of the music.

I also added the source codes of PlayListWidget component to GitHub.
Title: Re: Open ModPlug Player
Post by: Merlyn6175 on May 28, 2022, 13:39:51
Its gone quiet here, hope your OK. I know when I did a bit of programming, projects got started and sometime I was never motivated to complete them due to life priorities.
Title: Re: Open ModPlug Player
Post by: newbie on May 27, 2023, 22:57:32
Here is his GitHub page https://github.com/ModPlugPlayer/ModPlugPlayer (https://github.com/ModPlugPlayer/ModPlugPlayer)
It looks like he hasn't done anything on Github since Oct 26 2022. I hope he is okay.
Title: Re: Open ModPlug Player
Post by: Exhale on April 01, 2024, 16:49:45
Hi sunshine, I hope you are still ok and working on this project... I was thinking I might offer to lend a hand in the ways I can by offering to make skins for it.
It has been so long since you were working on this lovely little project, and I really hope you are still ok. If you have had life get in the way, maybe an offer for some graphical assistance might get you enthused on the project again, but if you dont reply I will try my very best to fork the project and add skins that way and maybe when you come back I will have skins to offer you.

EDIT : WARNING! WARNING!
do not drag and drop your tracks into any of the windows versions of this... it deletes the file! Fortunately I tested the drag and drop on a tune I had already uploaded to the modplug forums, but when I went to go drag and drop it again it wasnt there... YOU HAVE BEEN WARNED!

I added a warning on the git for other people too.