ModPlug Central

OpenMPT Development (Archive) => Bug Reports => Bug Report Archive => Topic started by: Inavon on April 07, 2010, 00:18:06

Title: 1.18.00.00 "Save as wave" never finishes
Post by: Inavon on April 07, 2010, 00:18:06
When I click "save as wave," it starts saving as normal, but when it reaches the end, it keeps on going. For example, a 5 minute song would reach 5 minutes, pass it, and keep going. I click stop, and the wave file turns out to be silent. I can hear the song when I play it using Modplug Tracker. This problem does not happen every time, but I found if it happens for one song, it will happen for another.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Rakib on April 07, 2010, 06:18:51
Have happened to me several times, but just try it again and it will work again.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: jmkz on April 07, 2010, 07:31:52
Check your song, verify the loop points of patterns and the restart pattern in the General tab, that is related with those things at least for me works. I used to add pattern loop events which causes this undesired effects when I render to wav.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on April 07, 2010, 10:06:28
djmakas, that won't help. I don't know why, but somtimes, MPT really just renders an infinite stream of silence. No complicated loop settings are needed, a simple one-pattern module with one note in it will be sufficient. After hitting play + stop, it will render OK again.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: jmkz on April 08, 2010, 05:28:09
Well some things like this happen to me, I am a litlle angry of this weird things, but anyway I dont which other actions I can do to avoid it, like a bug :?: when I open winamp and a song it corrupts the loading of some plugins for not say all.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Harbinger on April 10, 2010, 17:50:53
I agree, it's a "bug" -- it shouldn't happen and we don't want it to happen. It's happened to me several times, and i always thought it was a memory-caching issue. I save the track, restart MPT, and export to wave and it works fine...but it definitely should be looked into at some point. :?
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Skaven on July 07, 2010, 16:52:39
I think I have a repro case here... I added an empty pattern to the end of a song, with only Noteoffs in its beginning, so that I could create a seamless loop by mixing the instrument tails to the start of the .wav.

When rendering that song to a wave, I got the endless rendering issue over and over again (restart didn't help). However, when I added a few notes (with zero volume) to the pattern, it rendered to .wav OK.

I'll try to repro it again today.. if it happens again, I can send the song project over for debugging, if you like.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Skaven on July 07, 2010, 17:12:51
Quote from: "Skaven"I'll try to repro it again today.. if it happens again, I can send the song project over for debugging, if you like.
Couldn't repro it again. :(  Oh well...  (I tried deleting the zero volume notes, then rendering to wav again, but it rendered just fine)
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on July 07, 2010, 17:24:29
I'm not even sure if the bug is in the module renderer or if rather MPT files to allocate a mixing buffer or something. When I incorporate the new end of song detection code into the WAV renderer, time will show if it was indeed the module renderer which caused this operation to fail.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Inavon on July 12, 2010, 23:18:03
I think that if I play the song and save it while it's still playing, and reopen the song, the wav will render correctly.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on July 26, 2010, 13:22:12
While editing a tune, I just noticed that this might have something to do with using the "play row" button, but I couldn't reproduce it so far, so that might be a wrong lead. Can anyone confirm this?
Title: 1.18.00.00 "Save as wave" never finishes
Post by: phanoo on September 12, 2010, 16:42:06
I often have this bug, I don't tried to find how to reproduce it, but I just have to click Play 2 times (sometimes the first click does noting :shock: ) then Stop and Save as Wave will work.
I wonder if this bug appears like when the subwindow of MPT loses focus
Title: 1.18.00.00 "Save as wave" never finishes
Post by: phanoo on September 12, 2010, 16:46:10
I use a LOT OpenMPT (several hours/day) and it's the only major bug I have, so I think it should be a priority
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Rakib on September 12, 2010, 18:07:22
I think it is a priority, most of modplug users have had this problem, the only problem is that the bug is not reprodusable.
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on September 12, 2010, 18:09:18
In my eyes, a "priority" bug would be something that crashed the program or makes working with it impossible, but not something that can be fixed by using two shortcuts...
Title: 1.18.00.00 "Save as wave" never finishes
Post by: phanoo on September 27, 2010, 10:27:28
you should take care of the easiness/hardness to correct the bug. maybe it's easy to correct it, i don't know.
i'm a C/C++ developer, i've access to the SVN but i haven't enough time to take a look to....  :(
Title: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on September 27, 2010, 10:34:00
It is probably easy once you know where to look. I for once don't have a clue where to look because the obvious places I've checked weren't the reason fro this error...
Title: Re: 1.18.00.00 "Save as wave" never finishes
Post by: Saga Musix on April 11, 2012, 19:12:47
This has most likely been fixed. Please check if http://sagagames.de/stuff/mptrack.exe helps.