ModPlug Central

OpenMPT Development (Archive) => Bug Reports => Bug Report Archive => Topic started by: Sam_Zen on March 28, 2008, 01:44:49

Title: .50 Odd pattern menu
Post by: Sam_Zen on March 28, 2008, 01:44:49
It's not really a bug, because it doesn't do any harm, but more as inconvenient behaviour.

If a channel of a pattern is set to Solo, the context menu of that channel button shows also a choice of:
On transition : Solo

Quite superfluous I suppose.
Title: .50 Odd pattern menu
Post by: Saga Musix on April 03, 2008, 21:07:06
it is probably not. if you (accidently?) check "on trasition: unmute all", this is neccessary again. also, if you consider the order in which the 3 transition option (which i honestly have never checked), it may be also useful.
Title: .50 Odd pattern menu
Post by: Sam_Zen on April 03, 2008, 22:42:48
Of course, after "on transition: unmute all", the choice for "on transition : Solo" should be there again in the menu.
But it's quite irrelevant if the channel already is in a 'Solo' state.

The same would be, if a channel already is muted, to have a choice of "on transition: mute".
But in that case it's done correctly by changing the choice in the menu into "on transition: unmute".

Your reaction triggered me to check this again, and now I understand why this solo-option is there.

Because, if a channel is in solo-state, and one opens the context menu, there's no detection whether this is
the only enabled channel. So if 3 other channels are enabled too, it would give the same menu.
And in that case, the "on transition : Solo" is a valid option of course.
Title: .50 Odd pattern menu
Post by: Saga Musix on July 21, 2009, 21:04:01
Quote
Because, if a channel is in solo-state, and one opens the context menu, there's no detection whether this is
the only enabled channel.
This check is there (because the "solo" option won't be available), but as said, with the current implementation it's rather tricky to do this calculation both with the current state and the future state of all channels. I might look into this if I find some time, but it's not really important to me (especially since the channel context menu doesn't shop up in the pattern context menu anymore).
Title: .50 Odd pattern menu
Post by: Saga Musix on September 22, 2009, 21:44:43
Please confirm that this is fixed in OpenMPT 1.17.03.02. You may set the S=C flag in the first post yourself then, without further comments.