ModPlug Central

OpenMPT Development (Archive) => Bug Reports => Bug Report Archive => Topic started by: le_parasite on November 04, 2007, 23:30:35

Title: .48 long name tracks lead to crash of mpt in channel m
Post by: le_parasite on November 04, 2007, 23:30:35
Full Version:
OpenMPT v1.17.02.48

Has the bug occured in previous versions? If yes, please specify version(s): (This option is optional, and doesn't need research. But in case you know...)[/b]

dunno

Description of the bug:

long name tracks lead to crash of mpt in channel mode
e.g. Abdullah_Ibrahim

How often does it happen?:
constant


How to reproduce (step by step description):
give your track a long name like Abdullah_Ibrahim and render in channel mode....

I nearly went nuts as I looked for the reason of the bug!!

Edit By Mod: Changed topic title
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: pelya on November 05, 2007, 08:29:29
Cannot reproduce. Are you setting that "Abdullah_Ibrahim" as filename or as track title on MPT General View tab? Maybe you're saving rendered WAV files into directory with very long name? Does it crash right when you press  "Render" or in the middle of rendering?
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: Saga Musix on November 05, 2007, 12:08:14
Just a question... is the path name you are going to store the WAV files very long aswell?
example C:\Documents and Settings\le_parasite\Documents\modules\openmpt\blah\test folder\wav export\

This could be a limitation of file name length in Windows then and not a bug of OpenMPT. Try to export the WAV files to root (i.e. C:\) and see if it sill happens.
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: le_parasite on November 05, 2007, 22:30:07
Quote from: "Jojo"Just a question... is the path name you are going to store the WAV files very long aswell?
example C:\Documents and Settings\le_parasite\Documents\modules\openmpt\blah\test folder\wav export\

This could be a limitation of file name length in Windows then and not a bug of OpenMPT. Try to export the WAV files to root (i.e. C:\) and see if it sill happens.

you get it, the name of the module is 06_174_bbeat4b3.it and save location is on the XP  desktop C:\Documents and Settings\le parasite\Bureau\xxxxxxxx_bbeat! lol Changing the folder name with a shorter or erasing the track name, prevent mpt from crashing.
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: Sam_Zen on November 06, 2007, 01:01:23
This confirms my aversion against this ridicule M$ construction. I choose my own directories to work with.
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: LPChip on November 06, 2007, 07:57:55
You can solve this issue also using subst.

By creating a driveletter for a path, the path becomes alot shorter.

Example:

subst m: c:\docume~1\myuser\mydocu~1\music

could get you: m:\mysong.it
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: älskling on November 06, 2007, 09:57:19
Quote from: "Sam_Zen"This confirms my aversion against this ridicule M$ construction. I choose my own directories to work with.
How does an MPT bug confirm your aversion against which MS construction?
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: Saga Musix on November 06, 2007, 14:06:24
you didn't read correctly. it is NOT (!) a bug in MPT but Windows itself does not allow paths + filenames that are so long. That's only one of the reasons why i created my own "My Documents" folders on drive E:\ and F:\. Another reason is that games nowadays store their settings and savegames in the my documents folder which makes it less comfortable to browse - i mean, why are that my "own" documents?!
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: pelya on November 06, 2007, 15:18:09
There's buffer overflow somewhere in MPT anyway, 'cause MPT is one that crashed, not Windows ::) . All system functions should check filepath length and give some warning to user if it is too big (at least they meant to do so).
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: Relabsoluness on November 06, 2007, 20:00:30
Quote from: "Jojo"it is NOT (!) a bug in MPT but Windows itself does not allow paths + filenames that are so long.
As mentioned by pelya, it is a bug in MPT. What comes to the length limit, I have an impression that it is ~250 characters. That may not sound much, but try to create a path with that many characters ;).

2 le_parasite
Did some channels happen to have names?
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: le_parasite on November 07, 2007, 00:03:37
Quote from: "Relabsoluness"
2 le_parasite
Did some channels happen to have names?

Sorry if I wasn't clear enough, indeed by "tracks" I refered to channel

so the bug appeared with this path:

C:\Documents and Settings\le parasite\Bureau\xxxxxxxx_bbeat\06_174_bbeat4b3-008_Abdullah_Ibrahim.wav
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: älskling on November 07, 2007, 10:49:27
Quote from: "Jojo"you didn't read correctly. it is NOT (!) a bug in MPT but Windows itself does not allow paths + filenames that are so long.
Yes I did, yes it is and yes it does.  :wink:
Title: .48 long name tracks lead to crash of mpt in channel m
Post by: Relabsoluness on November 07, 2007, 20:46:57
Quote from: "le_parasite"Sorry if I wasn't clear enough, indeed by "tracks" I refered to channel
Thanks for the clarification; bug confirmed.
Title: Re: (S=P) .48 long name tracks lead to crash of mpt in chann
Post by: dBlues on December 17, 2007, 09:53:45
Quote from: "le_parasite"
I nearly went nuts as I looked for the reason of the bug!!

Edit By Mod: Changed topic title

le_parasite, I owe you my sanity for this - thanks!!!
Title: Re: (S=P) .48 long name tracks lead to crash of mpt in chann
Post by: le_parasite on December 17, 2007, 16:35:09
Quote from: "dBlues"
Quote from: "le_parasite"
I nearly went nuts as I looked for the reason of the bug!!

Edit By Mod: Changed topic title

le_parasite, I owe you my sanity for this - thanks!!!


ahahah glad to read that.
Title: export to wav in channel mode
Post by: vybes on November 18, 2008, 02:37:58
I've been crashing after exporting 11 channels as WAV, then I noticed this post and shortened the filename and directory path.
Now I noticed that channel 12 had spaces in the channel name, could that have been crashing MPT?

Shouldn't MPT replace those spaces with underscores or something?

Or maybe it was simply the file length.

I'm trying an export now with shorted channel names.
( I have 48 channels to export as separate wav files)


Awesome, it looks like they're all exporting properly!