Author Topic: Failed to compile code with VS2008  (Read 4695 times)

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Failed to compile code with VS2008
« on: August 18, 2011, 09:18:31 »
OpenMPT revision 983 is cannot be compilable. I got this errors:

Code: [Select]
s:\vc++\commit\mptrack\test\test.cpp(472) : error C2660: 'CWinApp::OpenDocumentFile' : la función no acepta 2 argumentos
s:\vc++\commit\mptrack\test\test.cpp(483) : error C2660: 'CWinApp::OpenDocumentFile' : la función no acepta 2 argumentos
s:\vc++\commit\mptrack\mptrack.cpp(75) : error C2660: 'CMultiDocTemplate::OpenDocumentFile' : la función no acepta 3 argumentos
s:\vc++\commit\mptrack\mainfrm.cpp(2185) : error C2660: 'CWinApp::OpenDocumentFile' : la función no acepta 2 argumentos

With VS2010 has no problems.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,461
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #1 on: August 18, 2011, 11:55:39 »
Known issue and is being worked on. I do not have VS2008 installed anymore so I cannot check what works in VS2008 and what doesn't.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #2 on: August 18, 2011, 15:28:47 »
Since r979 has this issue.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,461
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #3 on: August 18, 2011, 17:15:04 »
Since r979 has this issue.
Yes, we are aware of that. The change is required to make the treeview work in VS2010. A possible solution would be to add a preprocessor switch which uses the old code for VS2008 and older.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #4 on: August 19, 2011, 23:51:50 »
Yay! It's fixed! Thanks!

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #5 on: August 22, 2011, 19:42:56 »
Another issue with r993:

Code: [Select]
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(95) : error C3861: 'PathFileExists': no se encontró el identificador
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(664) : error C3861: 'PathFileExists': no se encontró el identificador
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(664) : error C3861: 'PathFileExists': no se encontró el identificador
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(713) : error C3861: 'PathIsDirectory': no se encontró el identificador
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(734) : error C3861: 'PathIsDirectory': no se encontró el identificador
8>c:\mpt\vc++\commit\mptrack\mptrack.cpp(746) : error C3861: 'PathIsDirectory': no se encontró el identificador

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,461
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #6 on: August 22, 2011, 21:13:29 »
That code isn't new, so you should probably do a complete rebuild of the executable and/or redownload the source.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #7 on: August 22, 2011, 22:03:33 »
Eight minutes after you commit the r995 I have recompiled and I got the same error.

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #8 on: August 24, 2011, 17:10:29 »
Patch for r998, same as Relabs one.

Offline jmkz

  • Workaholic artist
  • ***
  • Posts: 196
  • Gender: Male
  • Operating System: Windows 7 x64
Re: Failed to compile code with VS2008
« Reply #9 on: September 04, 2011, 08:35:44 »
Patch for fix "missing Reporting.h" at revision 1012+.