Author Topic: 1.18.02.00 Wrong pan value after conversion  (Read 2726 times)

Offline Sam_Zen

  • Extreme artist
  • *****
  • Posts: 3,689
    • http://www.xs4all.nl/~samzen/
1.18.02.00 Wrong pan value after conversion
« on: June 21, 2010, 00:31:00 »
I wanted to convert a 4 channel MOD to XM.
The default channel panning of a MOD is set to L - R - R - L.
With earlier versions of OMPT this got lost, so all channels were set to mono.
Now, the conversion works correct, so the Initial Pan values become 64 for L and 192 for R.

But there's a bug. Channel 1 is set to 128 (centered) instead of 64.
And with XM, the Initial Pan slider is greyed out, so it can't be corrected.
It's only channel 1. With a 12 CH MOD, channels 5 and 9 do have the correct 64.

Conversion of MOD to IT works correctly, and of course there the sliders are available for a change.
0.618033988

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,109
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
1.18.02.00 Wrong pan value after conversion
« Reply #1 on: June 21, 2010, 07:06:17 »
Thanks for pointing this out - it revealed that channel settings were neither set correctly for MOD, XM nor S3M when converting, due to a an error in the code which I didn't even expect to compile, but apparently it did.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,109
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
1.18.02.00 Wrong pan value after conversion
« Reply #2 on: August 04, 2010, 23:36:38 »
Please confirm that this has been fixed in OpenMPT 1.18.03.00. You may set the thread status to S=C then.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Sam_Zen

  • Extreme artist
  • *****
  • Posts: 3,689
    • http://www.xs4all.nl/~samzen/
1.18.02.00 Wrong pan value after conversion
« Reply #3 on: August 06, 2010, 12:03:15 »
(sorry for the delay)

Can't confirm this.
Now all channels are set to a value of 128
0.618033988

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,109
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
1.18.02.00 Wrong pan value after conversion
« Reply #4 on: August 06, 2010, 12:11:49 »
well, of course. xm doesn't have channel panning. xm only has sample panning, so all channels are just defaulted back to center.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Sam_Zen

  • Extreme artist
  • *****
  • Posts: 3,689
    • http://www.xs4all.nl/~samzen/
1.18.02.00 Wrong pan value after conversion
« Reply #5 on: August 07, 2010, 20:02:07 »
This would mean that my original prepatch bug should be read the other way :
Channel 1 is behaving correctly with 128 (centered), while channels 2 - 4 do it the wrong way, transferring 64 and 192
from the default MOD values.
0.618033988

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,109
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
1.18.02.00 Wrong pan value after conversion
« Reply #6 on: August 07, 2010, 20:02:46 »
Quote from: "Sam_Zen"
This would mean that my original prepatch bug should be read the other way :
Channel 1 is behaving correctly with 128 (centered), while channels 2 - 4 do it the wrong way, transferring 64 and 192
from the default MOD values.

I know. And exactly that has been fixed?
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Sam_Zen

  • Extreme artist
  • *****
  • Posts: 3,689
    • http://www.xs4all.nl/~samzen/
1.18.02.00 Wrong pan value after conversion
« Reply #7 on: August 10, 2010, 12:47:55 »
As such, yes.
0.618033988