Author Topic: 1.17.02.48 load sample fails with special character  (Read 4787 times)

Offline le_parasite

  • Inspired artist
  • **
  • Posts: 55
  • http://www.facebook.com/Le.parasite.000
    • FACEBOOK
  • Operating System: Windows SEVEN 64bit
1.17.02.48 load sample fails with special character
« on: March 11, 2008, 02:19:08 »
Full Version:
OpenMPT v1.17.02.48

Has the bug occured in previous versions?
I dont know



Description of the bug:

maybe due to some windows bug, but when you try to load a sample with special "letter", the sample won't load.

How often does it happen?:

always

How to reproduce (step by step description):

name a sample "Dvořák.wav" and try to upload it.

Edit: More information is available on the issue tracker.
« Last Edit: August 22, 2011, 19:28:09 by Jojo »

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,252
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
.48 load sample fails with special character
« Reply #1 on: March 11, 2008, 13:01:45 »
Hm, i sense unicode incompatiblities here...
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline Sam_Zen

  • Extreme artist
  • *****
  • Posts: 3,689
    • http://www.xs4all.nl/~samzen/
.48 load sample fails with special character
« Reply #2 on: March 11, 2008, 23:15:48 »
I guess so too.
0.618033988

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,252
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
.48 load sample fails with special character
« Reply #3 on: October 13, 2008, 20:13:25 »
The strange thing is that this filename is always passed as "Dvorák.wav" to MPT, not only when opening a sample but also in the treeview... So maybe the WinApi passes a "optimized for non-unicode platforms" version of that string to modplug...?
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline LPChip

  • Administrator
  • *****
  • Posts: 4,956
    • http://lpchip.nl
  • Operating System: Windows 10 Pro N (x64bit)
.48 load sample fails with special character
« Reply #4 on: October 14, 2008, 06:10:10 »
The ř char isn't part of the standard ascii table. Its an extended char, whereas the á is part of the standard ascii table.

And by standard, I mean 0-255.
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,252
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
.48 load sample fails with special character
« Reply #5 on: October 14, 2008, 09:41:40 »
I know that! :nuts: But I'm not sure what causes the bug here, maybe I have to learn about more about string types in C++....
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline bvanoudtshoorn

  • Extreme artist
  • *****
  • Posts: 1,053
  • Gender: Male
    • Barryvan
.48 load sample fails with special character
« Reply #6 on: October 14, 2008, 10:15:40 »
I'd guess that it's a conversion issue; ie, the filename's represented in format x in the system, is converted to format y for modplug, and then modplug tries to open the file using format y, and the system complains. But I'm just guessing.

This MSDN section might be useful, though.

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,252
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
.48 load sample fails with special character
« Reply #7 on: October 14, 2008, 12:13:41 »
Well, the filename is retrieved from a CFileDialog object. I directly tried to route that filename to a MessageBox (without a temporary variable) and it was still non-unicode.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.

Offline LPChip

  • Administrator
  • *****
  • Posts: 4,956
    • http://lpchip.nl
  • Operating System: Windows 10 Pro N (x64bit)
.48 load sample fails with special character
« Reply #8 on: October 14, 2008, 13:35:09 »
So this dialog gives the wrong filename back? Maybe there's a setting in the dialog to enable it. Otherwise, the control needs to be updated.
"Heh, maybe I should've joined the compo only because it would've meant I wouldn't have had to worry about a damn EQ or compressor for a change. " - Atlantis
"yes.. I think in this case it was wishful thinking: MPT is makng my life hard so it must be wrong" - Rewbs

Offline Saga Musix

  • OpenMPT Developers
  • *****
  • Posts: 6,252
  • aka Jojo
    • Download music, samples, VST plugins: Saga Musix Website
  • Operating System: Windows 7 x64
Re: 1.17.02.48 load sample fails with special character
« Reply #9 on: August 22, 2011, 19:27:47 »
I'll close this one as a related issue has been posted on the issue tracker.
» No support, bug reports, feature requests via private messages - they will not be answered. Use the forums and the issue tracker so that everyone can benefit from your post.